make deps less strict to work across trusty -> xenial #20

Merged
merged 1 commit into from Mar 24, 2016

Conversation

Projects
None yet
6 participants
Owner

marcoceppi commented Mar 23, 2016

This fixes the following traceback which will happen to any user or package using theblues.

Traceback (most recent call last):
  File "/usr/bin/charm-version", line 5, in <module>
    from pkg_resources import load_entry_point
  File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 3141, in <module>
    @_call_aside
  File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 3127, in _call_aside
    f(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 3154, in _initialize_master_working_set
    working_set = WorkingSet._build_master()
  File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 642, in _build_master
    return cls._build_from_requirements(__requires__)
  File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 655, in _build_from_requirements
    dists = ws.resolve(reqs, Environment())
  File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 833, in resolve
    raise VersionConflict(dist, req).with_context(dependent_req)
pkg_resources.ContextualVersionConflict: (requests 2.2.1 (/usr/lib/python2.7/dist-packages), Requirement.parse('requests==2.6.0'), set(['theblues']))

fixes #21

Member

jujugui commented Mar 23, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/theblues-lib/66/
Test PASSed.

Owner

hatched commented Mar 23, 2016

👍

Could you add some comments to the changes so that future us knows why it's a range?

Owner

marcoceppi commented Mar 23, 2016

Thanks @hatched I've updated the versions to be more inclusive. This will cover every version of python-requests from trusty to xenial

Member

jujugui commented Mar 23, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/theblues-lib/67/
Test PASSed.

== is never helpful in the context of packages - setting a minimum version is good tho - could we apply the same policy to all versions please? I think enforcing an upper limit should only be applied if there is a problem.

Member

jujugui commented Mar 24, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/theblues-lib/71/
Test PASSed.

Collaborator

bac commented Mar 24, 2016

On our projects we've gotten into the habit of specifying versions exactly, since we're installing from a download cache. For general use libraries like this one it is a mistake.

I like @javacruft's suggestion to provide minimum versions and drop the upper bound. I'd not expect that to happen in this change, though.

👍 with that change on requests only.

Owner

marcoceppi commented Mar 24, 2016

@bac I've dropped upper bands and replaced all == with >= - thanks for the feedback

Owner

urosj commented Mar 24, 2016

👍 ty

Member

jujugui commented Mar 24, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/theblues-lib/72/
Test PASSed.

@marcoceppi marcoceppi merged commit fc71051 into juju:develop Mar 24, 2016

1 check passed

default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment