Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
make deps less strict to work across trusty -> xenial #20
Conversation
|
Test PASSed. |
|
Could you add some comments to the changes so that future us knows why it's a range? |
|
Thanks @hatched I've updated the versions to be more inclusive. This will cover every version of python-requests from trusty to xenial |
|
Test PASSed. |
javacruft
commented
Mar 23, 2016
|
== is never helpful in the context of packages - setting a minimum version is good tho - could we apply the same policy to all versions please? I think enforcing an upper limit should only be applied if there is a problem. |
|
Test PASSed. |
|
On our projects we've gotten into the habit of specifying versions exactly, since we're installing from a download cache. For general use libraries like this one it is a mistake. I like @javacruft's suggestion to provide minimum versions and drop the upper bound. I'd not expect that to happen in this change, though. |
|
@bac I've dropped upper bands and replaced all == with >= - thanks for the feedback |
|
|
|
Test PASSed. |
marcoceppi commentedMar 23, 2016
This fixes the following traceback which will happen to any user or package using theblues.
fixes #21