/theblues

Provide default charm store URL #46

Merged
merged 1 commit into from Nov 3, 2016

Conversation

Reviewers

@howbazaar howbazaar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@johnsca @jujugui @petevg @howbazaar
@johnsca
Member

johnsca commented Oct 14, 2016 •
Edited 1 time

Supports overriding the default URL for backwards compatibility.

Fixes #45
@jujugui
Member

jujugui commented Oct 14, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/theblues-lib/159/
Test PASSed.
@petevg

petevg commented Oct 14, 2016 •
Edited 1 time

LGTM/+1 (disregard the earlier version of this comment complaining about formatting in the tests.)
theblues/utils.py
@@ -15,6 +15,8 @@
)
+API_URL = 'https://api.jujucharms.com/'
@howbazaar

howbazaar Nov 3, 2016

Owner

I think it would be better and a more minimal change to just set the API_URL to 'https://api.jujucharms.com/v5'

@johnsca
Provide default charm store URL 
Supports overriding the default URL for backwards compatibility.

Fixes #45
3b98f7d

@johnsca johnsca changed the title from Provide default charm store URL and API version to Provide default charm store URL Nov 3, 2016

@johnsca
Member

johnsca commented Nov 3, 2016

Simplified the diff based on review.
@jujugui
Member

jujugui commented Nov 3, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/theblues-lib/162/
Test PASSed.
@howbazaar
Owner

howbazaar commented Nov 3, 2016

:shipit:
@jujugui
Member

jujugui commented Nov 3, 2016

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/theblues-lib-merge

@jujugui jujugui merged commit 53b6038 into juju:develop Nov 3, 2016
1 check passed

1 check passed

default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment