/theblues

Accept cs: prefix on entity IDs #47

Merged
merged 1 commit into from Oct 18, 2016

Conversation

Reviewers

@bac bac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@johnsca @jujugui @petevg @bac
@johnsca
Member

johnsca commented Oct 14, 2016

The result from CharmStore.entityId() includes the cs: prefix, meaning
it can't be directly passed back in to the other methods. This change
makes all methods accept the cs: prefix.

Really, it should be accepted by the store API itself, but this seems
like a reasonable work-around.

Fixes #44
@johnsca
Accept cs: prefix on entity IDs 
The result from CharmStore.entityId() includes the cs: prefix, meaning
it can't be directly passed back in to the other methods.  This change
makes all methods accept the cs: prefix.

Really, it should be accepted by the store API itself, but this seems
like a reasonable work-around.

Fixes #44
afce2e2
@jujugui
Member

jujugui commented Oct 14, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/theblues-lib/160/
Test PASSed.
@petevg

petevg commented Oct 14, 2016

LGTM/+1
@bac

bac approved these changes Oct 18, 2016
View changes

This change looks reasonable @johnsca -- thanks for the patch.

@bac
Collaborator

bac commented Oct 18, 2016

:shipit:
@jujugui
Member

jujugui commented Oct 18, 2016

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/theblues-lib-merge

@jujugui jujugui merged commit 2cbfb95 into juju:develop Oct 18, 2016
1 check passed

1 check passed

default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment