Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Properly test no-op does the right thing, as does real errors. #28
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jameinel commentedApr 11, 2017
•
Edited 1 time
-
ericsnowcurrently
Apr 11, 2017
Oddly enough we didn't have a test that we handled errors correctly.
The issue is that often when raising an error, we also set the ops to empty,
so we have to check the error before we do the rest.
Add a test that we handle these cases correctly.
(Review request: http://reviews.vapour.ws/r/6516/)