Handle Bulk.Run() result being nil #37

Merged
merged 1 commit into from Jun 13, 2017

Conversation

Projects
None yet
3 participants

mjs commented Jun 13, 2017

If err is ErrNotFound then result will be nil, triggering a panic.

Fixes https://bugs.launchpad.net/juju/+bug/1697795

Handle Bulk.Run() result being nil
If err is ErrNotFound then result will be nil, triggering a panic.

Fixes https://bugs.launchpad.net/juju/+bug/1697795
Member

babbageclunk commented Jun 13, 2017

This seems like a bug in mgo though - Bulk.Run should return the accumulated result even when there's an error. (I think.)

mjs commented Jun 13, 2017

I agree, but in the mean time we need to do this

mjs commented Jun 13, 2017

$$merge$$

Contributor

jujubot commented Jun 13, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-txn

@jujubot jujubot merged commit dbb63c6 into juju:master Jun 13, 2017

@mjs mjs deleted the mjs:1697795-pruner-nil-handling branch Jun 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment