Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
utils: make uuid parsing more lenient #137
Conversation
|
LGTM, even if it allows UUIDs not following the RfC. That's a different topic, like discussed on irc. |
|
|
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-utils |
added a commit
that referenced
this pull request
Jun 4, 2015
jujubot
merged commit 16d187c
into
juju:master
Jun 4, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
rogpeppe commentedJun 4, 2015
This brings the UUID checking into line with the checking
done by UUID in juju/schema. There's no particular reason
to disallow other RFC4122 UUIDs. Once parsed
we treat the bytes as an opaque block, so whether it's
actually a version 4 UUID is immaterial.
(Review request: http://reviews.vapour.ws/r/1856/)