/utils

fslock: add NewLockWithClock function; maintain NewLock as backwardly compatible #166

Merged
merged 1 commit into from Oct 26, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rogpeppe @jujubot
@rogpeppe
Owner

rogpeppe commented Oct 26, 2015

Because NewLock had been changed backwardly incompatibly, it broke
any clients that used it unnecessarily. This maintains the old API
(which is more convenient for most clients) but adds the new functionality
using a new entry point.

(Review request: http://reviews.vapour.ws/r/2996/)
@rogpeppe
Owner

rogpeppe commented Oct 26, 2015

$$merge$$
@jujubot
Contributor

jujubot commented Oct 26, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-utils

jujubot added a commit that referenced this pull request Oct 26, 2015

@jujubot
Merge pull request #166 from rogpeppe/015-backwardly-compatible-fslock 
fslock: add NewLockWithClock function; maintain NewLock as backwardly compatible

Because NewLock had been changed backwardly incompatibly, it broke
any clients that used it unnecessarily. This maintains the old API
(which is more convenient for most clients) but adds the new functionality
using a new entry point.

(Review request: http://reviews.vapour.ws/r/2996/)
9cf41c7

@jujubot jujubot merged commit 9cf41c7 into juju:master Oct 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment