/utils

Fix LP 1536378 #190

Merged
merged 1 commit into from Jan 21, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@davecheney @jujubot
@davecheney
Contributor

davecheney commented Jan 21, 2016

Fixes LP #1536378

The logic inside isAlive was wrong, it was never executing the wait loop
so if two independent processes called isAlive (via clean) then they would
both think the lock is stale and attempt to break it.

The number of loop iterations if the alive file cannot be read is set to
an arbitrary value which will limit the max delay in tying to lock a dead lock
to 300 seconds.

(Review request: http://reviews.vapour.ws/r/3585/)
@davecheney
Fix LP 1536378 
Fixes LP #1536378

The logic inside isAlive was wrong, it was never executing the wait loop
so if two independent processes called isAlive (via clean) then they would
both think the lock is stale and attempt to break it.

The number of loop iterations if the alive file cannot be read is set to
an arbitary value which will limit the max delay in tying to lock a dead lock
to 300 seconds.
1a462c8
@davecheney
Contributor

davecheney commented Jan 21, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Jan 21, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-utils
@jujubot
Contributor

jujubot commented Jan 21, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-utils/80
@davecheney
Contributor

davecheney commented Jan 21, 2016

Bullshit, https://bugs.launchpad.net/juju-core/+bug/1536477

$$merge$$
@jujubot
Contributor

jujubot commented Jan 21, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-utils
@jujubot
Contributor

jujubot commented Jan 21, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-utils/81
@davecheney
Contributor

davecheney commented Jan 21, 2016

CI bot is fucked up, cannot tell time.

http://paste.ubuntu.com/14588528/
@davecheney
Contributor

davecheney commented Jan 21, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Jan 21, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-utils

jujubot added a commit that referenced this pull request Jan 21, 2016

@jujubot
Merge pull request #190 from davecheney/fixedbugs/1536378 
Fix LP 1536378

Fixes LP #1536378

The logic inside isAlive was wrong, it was never executing the wait loop
so if two independent processes called isAlive (via clean) then they would
both think the lock is stale and attempt to break it.

The number of loop iterations if the alive file cannot be read is set to
an arbitrary value which will limit the max delay in tying to lock a dead lock
to 300 seconds.

(Review request: http://reviews.vapour.ws/r/3585/)
93acddd

@jujubot jujubot merged commit 93acddd into juju:master Jan 21, 2016

rogpeppe added a commit to rogpeppe/juju-utils that referenced this pull request Jan 21, 2016

@jujubot @rogpeppe
Merge pull request #190 from davecheney/fixedbugs/1536378 
Fix LP 1536378

Fixes LP #1536378

The logic inside isAlive was wrong, it was never executing the wait loop
so if two independent processes called isAlive (via clean) then they would
both think the lock is stale and attempt to break it.

The number of loop iterations if the alive file cannot be read is set to
an arbitrary value which will limit the max delay in tying to lock a dead lock
to 300 seconds.

(Review request: http://reviews.vapour.ws/r/3585/)
68f3a3b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment