Add s390x as supported arch. #199

Merged
merged 1 commit into from Mar 9, 2016

Conversation

Projects
None yet
3 participants
Contributor

xnox commented Mar 9, 2016

Signed-off-by: Dimitri John Ledkov xnox@ubuntu.com

Contributor

xnox commented Mar 9, 2016

@cherylj on it. I guess I should be running tests too! How do I do that? I'll look into docs.

Add s390x as supported arch.
Signed-off-by: Dimitri John Ledkov <xnox@ubuntu.com>
Contributor

xnox commented Mar 9, 2016

I get

# github.com/juju/utils/packaging/manager_test
packaging/manager/manager_test.go:271: too few values in struct initializer
packaging/manager/utils_test.go:49: too few values in struct initializer

However, that's none of my doing.... Branch updated.

cherylj commented Mar 9, 2016

Yeah, that looks like you need to run godeps:

go get launchpad.net/godeps
cd $GOPATH/src/launchpad.net/godeps
go install ./...
cd $GOPATH/src/github.com/juju/utils
$GOPATH/bin/godeps -u dependencies.tsv

Then try and test again. I already tested this patch and it was fine.

cherylj commented Mar 9, 2016

$$fixes-1551276$$

Contributor

jujubot commented Mar 9, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-utils

Contributor

jujubot commented Mar 9, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-utils/97

cherylj commented Mar 9, 2016

$$merge$$

Contributor

jujubot commented Mar 9, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-utils

jujubot added a commit that referenced this pull request Mar 9, 2016

Merge pull request #199 from xnox/master
Add s390x as supported arch.

Signed-off-by: Dimitri John Ledkov <xnox@ubuntu.com>

@jujubot jujubot merged commit af32cfa into juju:master Mar 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment