Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
make outgoing address checker work under Go 1.7 #233
Conversation
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-utils |
jujubot
merged commit bdb77b0
into
juju:master
Aug 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
rogpeppe commentedAug 15, 2016
•
Edited 1 time
-
ericsnowcurrently
Aug 15, 2016
In Go 1.7, http.Transport introduced the DialContext field
which overrides the Dial field and is set in http.DefaultContext.
This means that our hack to override the Dial field to prevent
outgoing network connections in test doesn't work from
Go 1.7 onwards.
This PR fixes that. We change the tests to avoid patching
the dial call because there is no longer a single entry point,
so we use more functional checks instead, and do some
more comprehensive testing of the local address checking
logic.
(Review request: http://reviews.vapour.ws/r/5438/)