/utils

Replace Arch Linux support with "GenericLinux" #237

Merged
merged 3 commits into from Sep 15, 2016

Conversation

Reviewers

@howbazaar howbazaar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mjs @jujubot @howbazaar
@mjs
Contributor

mjs commented Sep 15, 2016 •
Edited 1 time

All Linuxes which aren't Ubuntu or CentOS will be classified as GenericLinux This is part of the work to allowing the client to work on all Linux variants.

Part of the fix for: https://bugs.launchpad.net/juju/+bug/1616531

Menno Smits added some commits Sep 14, 2016

Replace Arch with GenericLinux 
All Linuxes which aren't Ubuntu or CentOS will be classified as
GenericLinux.
65d818d
os: Add IsLinux and EquivalentTo to OSType 
The comparators will be used in upcoming changes to bootstrap tools
matching.
6cba850
series: Replace Arch support with GenericLinux 
This will allow all Linux variants to work with the client.
488db5f
@howbazaar

howbazaar approved these changes Sep 15, 2016
View changes

Not sure why CentOS is shown as "unknown" in the test.

Apart from that the change looks good.

series/series_linux_test.go
+ "unknown",
+ "OS release file is missing ID",
+}, {
+ `NAME="CentOS Linux"
@howbazaar

howbazaar Sep 15, 2016

Owner

Shouldn't we know about centos?

@mjs

mjs Sep 15, 2016

Contributor

That test is checking what happens when the os-release file says "CentOS" but there's no information to determine the CentOS series (hence the "could not determine series" error)

@mjs
Contributor

mjs commented Sep 15, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Sep 15, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-utils

@jujubot jujubot merged commit d7c6bbc into juju:master Sep 15, 2016

@mjs mjs deleted the mjs:genericlinux branch Sep 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment