Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh: Add StripCRReader for gocrypto on windows #251

Merged
merged 1 commit into from Nov 22, 2016

Conversation

bz2
Copy link
Contributor

@bz2 bz2 commented Nov 17, 2016

Fixes lp:1468752 by removing carriage returns from textual stdin
stream on windows when using gocrypto to communicate with remote
machine.

This is part one of making ssh from windows to a unix machine
more usable. Notably, this doesn't enable the passing of control
codes through to the remote shell, so for instance using a text
editor is still problematic.

QA steps

  • Build juju using this version of utils for windows.
  • Bootstrap with the resultant juju.exe
  • juju switch controller
  • juju.exe ssh 0
  • On remote machine, ls ~
  • See outout from ls and no other kipple.
  • Run other commands as well, note vi somefile is still not usable.

Fixes lp:1468752 by removing carriage returns from textual stdin
stream on windows when using gocrypto to communicate with remote
machine.

This is part one of making ssh from windows to a unix machine
more usable. Notably, this doesn't enable the passing of control
codes through to the remote shell, so for instance using a text
editor is still problematic.
Copy link
Contributor

@natefinch natefinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I'd make WrapStdin just check runtime.GOOS so that we don't need two files for single line functions, and it means you can test it more easily from any platform. However, I don't think it's a dealbreaker.

Copy link
Contributor

@natefinch natefinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, meant to make the one above an approve, but forgot to set it, and there seems to be no way to change that after the fact.

@bz2
Copy link
Contributor Author

bz2 commented Nov 22, 2016

$$merge$$

@jujubot
Copy link
Contributor

jujubot commented Nov 22, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-utils

@jujubot jujubot merged commit 4559f40 into juju:master Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants