ssh: Add StripCRReader for gocrypto on windows #251
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes lp:1468752 by removing carriage returns from textual stdin
stream on windows when using gocrypto to communicate with remote
machine.
This is part one of making ssh from windows to a unix machine
more usable. Notably, this doesn't enable the passing of control
codes through to the remote shell, so for instance using a text
editor is still problematic.
QA steps
juju switch controller
juju.exe ssh 0
ls ~
vi somefile
is still not usable.