Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
ssh: Add StripCRReader for gocrypto on windows #251
Conversation
natefinch
reviewed
Nov 17, 2016
Personally, I'd make WrapStdin just check runtime.GOOS so that we don't need two files for single line functions, and it means you can test it more easily from any platform. However, I don't think it's a dealbreaker.
natefinch
approved these changes
Nov 17, 2016
Sorry, meant to make the one above an approve, but forgot to set it, and there seems to be no way to change that after the fact.
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-utils |
jujubot
merged commit 4559f40
into
juju:master
Nov 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
bz2 commentedNov 17, 2016
Fixes lp:1468752 by removing carriage returns from textual stdin
stream on windows when using gocrypto to communicate with remote
machine.
This is part one of making ssh from windows to a unix machine
more usable. Notably, this doesn't enable the passing of control
codes through to the remote shell, so for instance using a text
editor is still problematic.
QA steps
juju switch controllerjuju.exe ssh 0ls ~vi somefileis still not usable.