Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
series: don't consider pre-release series LTS #288
Conversation
|
$$merge$$ |
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju-utils |
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju-utils |
jujubot
merged commit 0be7bba
into
juju:master
Oct 25, 2017
jameinel
reviewed
Oct 25, 2017
another comment is that we should probably move the check to Trusty instead of precise because I don't think we actually support Precise builds of new Juju
|
looking here I only see 2.1.2 for precise |
dhenrich
commented
Oct 25, 2017
|
Let's make sure we do this in a way that we never have to fix this again. This seems to have been a reoccurring theme over the years. |
nskaggs
referenced this pull request
in juju/juju
Oct 25, 2017
Merged
Update juju utils for pre-release LTS check #7963
added a commit
to juju/juju
that referenced
this pull request
Oct 25, 2017
added a commit
to axw/juju
that referenced
this pull request
Oct 25, 2017
axw
referenced this pull request
in juju/juju
Oct 25, 2017
Merged
Update juju/utils in dependencies.tsv #7966
added a commit
to juju/juju
that referenced
this pull request
Oct 26, 2017
hloeung
commented
Oct 30, 2017
•
|
Would it be better to work out the default distro to use based off the streams image cache instead (so cache of either internal streams for private clouds such as our ProdStack or public streams.c.c)? On new release, distro-info-data may have been updated on said host but it's possible that said "cloud" used by selected model may not have the image sync'ed and available. |
|
@hloeung yes, I think so: if the user hasn't specified a series, then use the most recent LTS available in both the image and agent repositories. |
axw commentedOct 25, 2017
If a series says LTS, but is pre-release, don't
record it as LTS. This is a bit hackish, but
stops us from selecting it as a default series.