series: don't consider pre-release series LTS #288

Merged
merged 1 commit into from Oct 25, 2017

Conversation

Projects
None yet
5 participants
Member

axw commented Oct 25, 2017

If a series says LTS, but is pre-release, don't
record it as LTS. This is a bit hackish, but
stops us from selecting it as a default series.

series: don't consider pre-release series LTS
If a series says LTS, but is pre-release, don't
record it as LTS. This is a bit hackish, but
stops us from selecting it as a default series.

but won't this test break in 2094? :)

Owner

jameinel commented Oct 25, 2017

$$merge$$

Contributor

jujubot commented Oct 25, 2017

Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju-utils

Contributor

jujubot commented Oct 25, 2017

Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju-utils

@jujubot jujubot merged commit 0be7bba into juju:master Oct 25, 2017

another comment is that we should probably move the check to Trusty instead of precise because I don't think we actually support Precise builds of new Juju

Let's make sure we do this in a way that we never have to fix this again. This seems to have been a reoccurring theme over the years.

@nskaggs nskaggs referenced this pull request in juju/juju Oct 25, 2017

Merged

Update juju utils for pre-release LTS check #7963

jujubot added a commit to juju/juju that referenced this pull request Oct 25, 2017

Merge pull request #7963 from nskaggs/2.2
Update juju utils for pre-release LTS check

## Description of change

See juju/utils#288

Juju needs to not consider pre-release versions of the LTS as the default bootstrap series

axw added a commit to axw/juju that referenced this pull request Oct 25, 2017

Update juju/utils in dependencies.tsv
See juju/utils#288

Juju needs to not consider pre-release versions of the LTS as the
default bootstrap series.

@axw axw referenced this pull request in juju/juju Oct 25, 2017

Merged

Update juju/utils in dependencies.tsv #7966

jujubot added a commit to juju/juju that referenced this pull request Oct 26, 2017

Merge pull request #7966 from axw/update-utils-dependency
Update juju/utils in dependencies.tsv

See juju/utils#288

Juju needs to not consider pre-release versions of the LTS as the
default bootstrap series.

hloeung commented Oct 30, 2017

Would it be better to work out the default distro to use based off the streams image cache instead (so cache of either internal streams for private clouds such as our ProdStack or public streams.c.c)?

On new release, distro-info-data may have been updated on said host but it's possible that said "cloud" used by selected model may not have the image sync'ed and available.

Member

axw commented Oct 30, 2017

@hloeung yes, I think so: if the user hasn't specified a series, then use the most recent LTS available in both the image and agent repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment