Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
make group #3 non-capturing, since we never reference it. #2
Conversation
mbruzek
commented
Mar 22, 2016
|
I checked the new regular expression with https://regex101.com/ and the following versions came back correctly:
Looking at the code, the sub 5 seems OK for this last test case. Are there tests for the version that need to be updated? Is there any other use of the version regex in the code? |
|
both are only ever used in the one spot, and there's a bunch of tests, so I'm pretty confident it's ok. |
|
Please resolve conflicts so that we can review. |
|
LGTM. |
|
|
reedobrien
closed this
Sep 16, 2016
natefinch
reopened this
Sep 16, 2016
natefinch
merged commit 94d843f
into
juju:master
Sep 16, 2016
|
sorry, not sure how I hit the close button. must have double tabbed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
natefinch commentedMar 22, 2016
This makes the code a little easier to follow, and we remove the nested groups which are kind of confusing.