Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Copy in interfaces rather than using encoding module import #4
Conversation
rogpeppe
reviewed
Apr 13, 2015
| +// marshal itself into a textual form. | ||
| +// | ||
| +// MarshalText encodes the receiver into UTF-8-encoded text and returns the result. | ||
| +type TextMarshaler interface { |
rogpeppe
reviewed
Apr 13, 2015
| +// UnmarshalText must be able to decode the form generated by MarshalText. | ||
| +// UnmarshalText must copy the text if it wishes to retain the text | ||
| +// after returning. | ||
| +type TextUnmarshaler interface { |
|
LGTM with two trivial changes, thanks! |
|
Have done the lowercasing as suggested. |
pushed a commit
that referenced
this pull request
Apr 13, 2015
bz2
merged commit eb759a6
into
juju:master
Apr 13, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
bz2 commentedApr 13, 2015
Workaround odd gccgo issue, which fails with errors along the lines of:
../xml/marshal.go:10:2: cannot find package "encoding" in any of:
/usr/src/pkg/encoding (from $GOROOT)
As this forked code only imports encoding for the TextMarshaler and TextUnmarshaler interface, just bring those in where they're used and drop the import.