toString and valueOf #7

Merged
merged 1 commit into from May 27, 2012

Projects

None yet

2 participants

@dfellis
Contributor
dfellis commented May 26, 2012

Here are the toString and valueOf implementations as I said I'd implement first, as well as tests for their proper behavior.

I have to note that you can't run rake build and get a minified file due to the fact that the indicated .jar file is outside of the repo and it's name is too generic for me to google it.

Can I recommend converting /src/SpahQL.js to require() all of the other js files Node.js-style, then use node-browserify to merge them together and strip the require()s back out, and then use UglifyJS to minify the resulting file? I suggest this because you already require nodeunit for tests so Node.js is needed, and make, rake, and bundle are all superfluous to this Javascript-based project (and not every JS dev is familiar with the Ruby build tools).

@dfellis dfellis Added valueOf and toString properties for db object and query subobje…
…cts, and tests for their behavior. Also built library (but don't have specified minifier), and added in the 'nodeunit' devDependencies entry so running 'make' works to test.
d636cea
@julesfern
Owner

It's true, the build system is a filthy hodgepodge put together by me in a hurry. I'll create a fresh ticket to sort this out, and I agree in principle with the technology selection. Meanwhile, thanks for the push!

@julesfern julesfern merged commit feea754 into julesfern:master May 27, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment