Skip to content

Fix parsing of unterminated brackets #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Fix parsing of unterminated brackets #362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/components/lists.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,9 @@ function parse_array_outer(ps::ParseState, trivia, isref)
push!(trivia, accept_comma(ps))
@closesquare ps parse_comma_sep(ps, args, trivia, isref, insert_params_at = 1)
return EXPR(:vect, args, trivia)
elseif kindof(ps.nt) === Tokens.ENDMARKER
push!(args, a)
return EXPR(:vect, args, trivia)
end
end
is_start = false
Expand Down
7 changes: 7 additions & 0 deletions test/parser.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,6 +480,13 @@ end
@test "[1,2,3,4,5]" |> test_expr
# this is nonsensical, but iteration should still work
@test traverse(CSTParser.parse(raw"""[[:alpha:]a←-]"""))
# unterminated expressions may cause issues
@test traverse(CSTParser.parse("bind_artifact!(\"../Artifacts.toml\",\"example\",hash,download_info=[(\"file://c:/juliaWork/tarballs/example.tar.gz\"\",tarball_hash)],force=true)\n2+2\n"))
@test traverse(CSTParser.parse("[2+3+4"))
@test traverse(CSTParser.parse("[2+3+4+"))
@test traverse(CSTParser.parse("[\"hi\"\""))
@test traverse(CSTParser.parse("[\"hi\"\"\n"))
@test traverse(CSTParser.parse("[(1,2,3])"))
end

@testset "ref" begin
Expand Down