LanguageServer crashes on `public` keyword

[filchristou]

2025-01-10T15:59:14.454 helix_lsp::transport [ERROR] julia-lsp err <- "ERROR: Indexing   1:28  public( )\n"
2025-01-10T15:59:14.454 helix_lsp::transport [ERROR] julia-lsp err <- "  1:21   is_low_level_intent at 1\n"
2025-01-10T15:59:14.454 helix_lsp::transport [ERROR] julia-lsp err <- "Stacktrace:\n"
2025-01-10T15:59:14.454 helix_lsp::transport [ERROR] julia-lsp err <- "  [1] error(s::String)\n"
2025-01-10T15:59:14.454 helix_lsp::transport [ERROR] julia-lsp err <- "    @ Base ./error.jl:35\n"
2025-01-10T15:59:14.454 helix_lsp::transport [ERROR] julia-lsp err <- "  [2] _getindex(x::CSTParser.EXPR, i::Int64)\n"
2025-01-10T15:59:14.454 helix_lsp::transport [ERROR] julia-lsp err <- "    @ CSTParser.Iterating ~/.julia/packages/CSTParser/0hXvH/src/iterate.jl:186\n"
2025-01-10T15:59:14.454 helix_lsp::transport [ERROR] julia-lsp err <- "  [3] getindex(x::CSTParser.EXPR, i::Int64)\n"
2025-01-10T15:59:14.454 helix_lsp::transport [ERROR] julia-lsp err <- "    @ CSTParser.Iterating ~/.julia/packages/CSTParser/0hXvH/src/iterate.jl:6\n"
2025-01-10T15:59:14.455 helix_lsp::transport [ERROR] julia-lsp err <- "  [4] collect_hints(x::CSTParser.EXPR, env::StaticLint.ExternalEnv, missingrefs::Symbol, isquoted::Bool, errs::Vector{Tuple{Int64, CSTParser.EXPR}}, pos::Int64) (repeats 4 times)\n"
2025-01-10T15:59:14.455 helix_lsp::transport [ERROR] julia-lsp err <- "    @ StaticLint ~/.julia/packages/StaticLint/vmUKQ/src/linting/checks.jl:635\n"
2025-01-10T15:59:14.455 helix_lsp::transport [ERROR] julia-lsp err <- "  [5] collect_hints(x::CSTParser.EXPR, env::StaticLint.ExternalEnv, missingrefs::Symbol)\n"
2025-01-10T15:59:14.455 helix_lsp::transport [ERROR] julia-lsp err <- "    @ StaticLint ~/.julia/packages/StaticLint/vmUKQ/src/linting/checks.jl:612\n"
2025-01-10T15:59:14.455 helix_lsp::transport [ERROR] julia-lsp err <- "  [6] mark_errors(doc::LanguageServer.Document, out::Vector{LanguageServer.Diagnostic})\n"
2025-01-10T15:59:14.455 helix_lsp::transport [ERROR] julia-lsp err <- "    @ LanguageServer ~/.julia/packages/LanguageServer/Fwm1f/src/requests/textdocument.jl:139\n"
2025-01-10T15:59:14.455 helix_lsp::transport [ERROR] julia-lsp err <- "  [7] lint!(doc::LanguageServer.Document, server::LanguageServerInstance)\n"
2025-01-10T15:59:14.455 helix_lsp::transport [ERROR] julia-lsp err <- "    @ LanguageServer ~/.julia/packages/LanguageServer/Fwm1f/src/staticlint.jl:77\n"
2025-01-10T15:59:14.455 helix_lsp::transport [ERROR] julia-lsp err <- "  [8] textDocument_didChange_notification(params::LanguageServer.DidChangeTextDocumentParams, server::LanguageServerInstance, conn::JSONRPC.JSONRPCEndpoint{Base.PipeEndpoint, Base.PipeEndpoint})\n"
2025-01-10T15:59:14.455 helix_lsp::transport [ERROR] julia-lsp err <- "    @ LanguageServer ~/.julia/packages/LanguageServer/Fwm1f/src/requests/textdocument.jl:106\n"
2025-01-10T15:59:14.464 helix_lsp::transport [ERROR] julia-lsp err <- "  [9] (::LanguageServer.var\"#116#117\"{typeof(LanguageServer.textDocument_didChange_notification), LanguageServerInstance})(conn::JSONRPC.JSONRPCEndpoint{Base.PipeEndpoint, Base.PipeEndpoint}, params::LanguageServer.DidChangeTextDocumentParams)\n"
2025-01-10T15:59:14.464 helix_lsp::transport [ERROR] julia-lsp err <- "    @ LanguageServer ~/.julia/packages/LanguageServer/Fwm1f/src/languageserverinstance.jl:273\n"
2025-01-10T15:59:14.464 helix_lsp::transport [ERROR] julia-lsp err <- " [10] dispatch_msg(x::JSONRPC.JSONRPCEndpoint{Base.PipeEndpoint, Base.PipeEndpoint}, dispatcher::JSONRPC.MsgDispatcher, msg::Dict{String, Any})\n"
2025-01-10T15:59:14.464 helix_lsp::transport [ERROR] julia-lsp err <- "    @ JSONRPC ~/.julia/packages/JSONRPC/RIWyo/src/typed.jl:67\n"
2025-01-10T15:59:14.464 helix_lsp::transport [ERROR] julia-lsp err <- " [11] run(server::LanguageServerInstance; timings::Vector{Any})\n"
2025-01-10T15:59:14.464 helix_lsp::transport [ERROR] julia-lsp err <- "    @ LanguageServer ~/.julia/packages/LanguageServer/Fwm1f/src/languageserverinstance.jl:405\n"
2025-01-10T15:59:14.464 helix_lsp::transport [ERROR] julia-lsp err <- " [12] run\n"
2025-01-10T15:59:14.464 helix_lsp::transport [ERROR] julia-lsp err <- "    @ ~/.julia/packages/LanguageServer/Fwm1f/src/languageserverinstance.jl:283 [inlined]\n"
2025-01-10T15:59:14.464 helix_lsp::transport [ERROR] julia-lsp err <- " [13] runserver(pipe_in::Base.PipeEndpoint, pipe_out::Base.PipeEndpoint, env_path::String, depot_path::String, err_handler::Nothing, symserver_store_path::Nothing)\n"
2025-01-10T15:59:14.464 helix_lsp::transport [ERROR] julia-lsp err <- "    @ LanguageServer ~/.julia/packages/LanguageServer/Fwm1f/src/runserver.jl:41\n"
2025-01-10T15:59:14.465 helix_lsp::transport [ERROR] julia-lsp err <- " [14] runserver()\n"
2025-01-10T15:59:14.465 helix_lsp::transport [ERROR] julia-lsp err <- "    @ LanguageServer ~/.julia/packages/LanguageServer/Fwm1f/src/runserver.jl:39\n"
2025-01-10T15:59:14.465 helix_lsp::transport [ERROR] julia-lsp err <- " [15] top-level scope\n"
2025-01-10T15:59:14.465 helix_lsp::transport [ERROR] julia-lsp err <- "    @ none:1\n"
2025-01-10T15:59:14.684 helix_lsp::transport [ERROR] julia-lsp err: <- StreamClosed

(@helix-lsp) pkg> st
Status `~/.julia/environments/helix-lsp/Project.toml`
  [2b0e0bc5] LanguageServer v4.5.1

julia> versioninfo()
Julia Version 1.11.2
Commit 5e9a32e7af2 (2024-12-01 20:02 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 32 × AMD Ryzen 9 7945HX with Radeon Graphics
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver4)
Threads: 1 default, 0 interactive, 1 GC (on 32 virtual cores)

I think it's similar to the problem described here
#1224 (comment)

[pfitzseb]

What's pkg> st -m print? You might need to get on CSTParser/StaticLint/LanguageServer master for now.

[tpapp]

I can replicate the issue with

(@v1.11) pkg> st -m StaticLint
Status `~/.julia/environments/v1.11/Manifest.toml`
  [b3cc710f] StaticLint v8.2.2

(@v1.11) pkg> st -m LanguageServer
Status `~/.julia/environments/v1.11/Manifest.toml`
  [2b0e0bc5] LanguageServer v4.5.1

(@v1.11) pkg> st -m CSTParser
Status `~/.julia/environments/v1.11/Manifest.toml`
  [00ebfdb7] CSTParser v3.4.3

julia> VERSION
v"1.11.2"

I tried master for everything, but

(@v1.11) pkg> dev CSTParser LanguageServer SymbolServer StaticLint

does not fix the issue for me.

[pfitzseb]

Any chance you can share the code that triggers this error?

[filchristou]

This toy repo triggers the error for me
https://github.com/filchristou/PublicLSBug

[filchristou]

Now that I am on master in CSTParser/StaticLint/LanguageServer it doesn't break anymore.
However the LSP still cannot identify the references in public (Missing reference: ...)