Skip to content

Conversation

@pfitzseb
Copy link
Member

@pfitzseb pfitzseb commented Mar 18, 2022

This is more inefficient but also more correct.

Crucially, we can't rely on the fact that iterating over parentof(x) will yield x at any point. This basically only comes up with generators, so it might make more sense to fix the iteration protocol instead.

@pfitzseb pfitzseb requested a review from davidanthoff March 18, 2022 15:00
@davidanthoff davidanthoff merged commit 50d7a09 into master Mar 19, 2022
@davidanthoff davidanthoff deleted the sp/fix-get_file_loc branch March 19, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants