From 843a22ca0358984152aa5692e3e16970032469f9 Mon Sep 17 00:00:00 2001
From: ZacNugent <zac.nugent@gmail.com>
Date: Thu, 7 May 2020 16:00:23 +0100
Subject: [PATCH 1/2] support for func arg use check in SL

---
 src/protocol/basic.jl        | 6 ++----
 src/requests/textdocument.jl | 6 +++++-
 src/requests/workspace.jl    | 1 +
 3 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/src/protocol/basic.jl b/src/protocol/basic.jl
index c9623894..d876168b 100644
--- a/src/protocol/basic.jl
+++ b/src/protocol/basic.jl
@@ -58,10 +58,8 @@ const DiagnosticSeverities = (Error = 1,
                               Hint = 4)
 
 const DiagnosticTag = Int
-const DiagnosticTags = (Error = 1,
-                        Warning = 2,
-                        Information = 3,
-                        Hint = 4)
+const DiagnosticTags = (Unnecessary = 1,
+                        Deprecated = 2)
 
 struct DiagnosticRelatedInformation
     location::Location
diff --git a/src/requests/textdocument.jl b/src/requests/textdocument.jl
index 56e0b097..2dad6459 100644
--- a/src/requests/textdocument.jl
+++ b/src/requests/textdocument.jl
@@ -305,7 +305,11 @@ function mark_errors(doc, out = Diagnostic[])
                     elseif CSTParser.isidentifier(errs[i][2]) && !StaticLint.haserror(errs[i][2])
                         push!(out, Diagnostic(Range(r[1] - 1, r[2], line - 1, char), DiagnosticSeverities.Warning, "Julia", "Julia", "Missing reference: $(errs[i][2].val)", missing, missing))
                     elseif StaticLint.haserror(errs[i][2]) && StaticLint.errorof(errs[i][2]) isa StaticLint.LintCodes
-                        push!(out, Diagnostic(Range(r[1] - 1, r[2], line - 1, char), DiagnosticSeverities.Information, "Julia", "Julia", get(StaticLint.LintCodeDescriptions, StaticLint.errorof(errs[i][2]), ""), missing, missing))
+                        if  StaticLint.errorof(errs[i][2]) === StaticLint.UnusedFunctionArgument
+                            push!(out, Diagnostic(Range(r[1] - 1, r[2], line - 1, char), DiagnosticSeverities.Hint, "Julia", "Julia", get(StaticLint.LintCodeDescriptions, StaticLint.errorof(errs[i][2]), ""), [DiagnosticTags.Unnecessary], missing))
+                        else
+                            push!(out, Diagnostic(Range(r[1] - 1, r[2], line - 1, char), DiagnosticSeverities.Information, "Julia", "Julia", get(StaticLint.LintCodeDescriptions, StaticLint.errorof(errs[i][2]), ""), missing, missing))
+                        end
                     end
                     i += 1
                     i>n && break
diff --git a/src/requests/workspace.jl b/src/requests/workspace.jl
index 7c610e04..fe5a6a0c 100644
--- a/src/requests/workspace.jl
+++ b/src/requests/workspace.jl
@@ -107,6 +107,7 @@ function request_julia_config(server)
             response[N + 7]===nothing ? false : response[N + 7],
             response[N + 8]===nothing ? false : response[N + 8],
             response[N + 9]===nothing ? false : response[N + 9],
+            response[N + 10]===nothing ? false : response[N + 10],
         )
         
         new_run_lint_value = x===nothing ? false : true

From eac9a19e41be8ba351e47301d41348e719fcfcb9 Mon Sep 17 00:00:00 2001
From: ZacNugent <zac.nugent@gmail.com>
Date: Thu, 7 May 2020 16:57:37 +0100
Subject: [PATCH 2/2] bump dep ver

---
 Project.toml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Project.toml b/Project.toml
index a1ddb89c..4aea0b36 100644
--- a/Project.toml
+++ b/Project.toml
@@ -26,7 +26,7 @@ JSON = "0.20, 0.21"
 julia = "1"
 CSTParser = "2.2"
 DocumentFormat = "2.1"
-StaticLint = "4"
+StaticLint = "4.1"
 Tokenize = "0.5.7"
 SymbolServer = "4.2"
 URIParser = "0.4.1"