Skip to content

Conversation

@epolack
Copy link

@epolack epolack commented Oct 15, 2023

I have updated the doc regarding the @testsetup functionality.

Moreover, I have noticed that cross-module usage is possible, and can come really handy for some complicated set of tests. I have added documentation and tests regarding this as well.
Was it done on purpose, and can I expect it to keep working in the future?

(Also, thanks for this piece of software; I find it extremely useful.)

@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Merging #57 (c110489) into main (993a923) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files           2        2           
  Lines         115      115           
=======================================
  Hits          113      113           
  Misses          2        2           
Flag Coverage Δ
unittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kenahoo
Copy link

kenahoo commented Jun 4, 2024

Any chance this will get merged soon? I didn't know about the setup functionality, is that officially supported?

getfloat() = rand()
end
```

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this definition have to occur in a specific place in a package, which should be mentioned here? Or will it be picked up anywhere in the codebase? I'm asking because with TestItemRunner v0.2.3, I can't seem to get a TestSetup created that's recognized within my @testitem sections (I put the @testsetup section in my runtests.jl).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my experience, where I put TestItemRunner stuff only in test/ it should be picked from anywhere.

@davidanthoff
Copy link
Member

The setup stuff is not yet fully implemented (it doesn't exist in the VS Code extension), so we should hold off merging this until the feature is actually fully there. I've started working on the VS Code side of things again, so I'm making progress on it.

@kenahoo
Copy link

kenahoo commented Jun 4, 2024

Awesome, thanks for the update @davidanthoff . I'll be watching this space!

@davidanthoff
Copy link
Member

I ended up changing the implementation quite a bit, so I'm closing this as the docs will have to be different. BUT, I'm very close to releasing this feature across the entire ecosystem, and once the builds are out everywhere I'll write docs here. Thanks for the PR, though!

@epolack epolack deleted the doc branch July 15, 2024 14:31
@epolack epolack restored the doc branch July 15, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants