-
Notifications
You must be signed in to change notification settings - Fork 16
Doc for testsetup and cross-module testing
#57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #57 +/- ##
=======================================
Coverage 98.26% 98.26%
=======================================
Files 2 2
Lines 115 115
=======================================
Hits 113 113
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Any chance this will get merged soon? I didn't know about the setup functionality, is that officially supported? |
| getfloat() = rand() | ||
| end | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this definition have to occur in a specific place in a package, which should be mentioned here? Or will it be picked up anywhere in the codebase? I'm asking because with TestItemRunner v0.2.3, I can't seem to get a TestSetup created that's recognized within my @testitem sections (I put the @testsetup section in my runtests.jl).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my experience, where I put TestItemRunner stuff only in test/ it should be picked from anywhere.
|
The setup stuff is not yet fully implemented (it doesn't exist in the VS Code extension), so we should hold off merging this until the feature is actually fully there. I've started working on the VS Code side of things again, so I'm making progress on it. |
|
Awesome, thanks for the update @davidanthoff . I'll be watching this space! |
|
I ended up changing the implementation quite a bit, so I'm closing this as the docs will have to be different. BUT, I'm very close to releasing this feature across the entire ecosystem, and once the builds are out everywhere I'll write docs here. Thanks for the PR, though! |
I have updated the doc regarding the
@testsetupfunctionality.Moreover, I have noticed that cross-module usage is possible, and can come really handy for some complicated set of tests. I have added documentation and tests regarding this as well.
Was it done on purpose, and can I expect it to keep working in the future?
(Also, thanks for this piece of software; I find it extremely useful.)