Skip to content

Conversation

@pfitzseb
Copy link
Member

We've gotten a bunch of reports of people being annoyed/confused about the play button starting a new process/taking a long time/not using the correct launch config (this last one is because of a VSCode bug, I think).

This switches it to the in-process "Run File" command, which imho people should be using anyways. It also changes the names for "Run File"/"Debug File" to clarify that those start a new process.

and have more descriptive name for out-of-process run/dbeug
Copy link
Member

@aviatesk aviatesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.

pfitzseb and others added 2 commits November 1, 2020 11:58
Co-authored-by: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com>
Co-authored-by: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com>
@pfitzseb pfitzseb merged commit 20a72b1 into master Nov 2, 2020
@aviatesk aviatesk deleted the sp/betterrunfile branch November 2, 2020 09:35
@oppo-source oppo-source removed the request for review from a team April 16, 2021 07:35
@david-hofmann
Copy link

Dear developers! I have a comment regarding the behavior of the play button. My team and I were puzzled when we noticed that a line-by-line evaluation of the Julia code works fine but when running the whole script at once it threw an error. It took a while until we realized that the code that it ran was simply not the visible code but the file's content (and the current status wasn't saved).

This behavior of the play (or run) button doesn't seem intuitive. I figure it is because that button essentially executes what is spelled out in launch.json which (in its default form) runs the file on the harddrive.
However, for instance the Python IDE Spyder saves a file when clicking the run button and thus executes the visible version. I find that behavior more intuitive if it is too complicated to run the code that is present in working memory and thus the one that one sees on screen. I don't see an immediate disadvantage of automatically saving when clicking the run button. Would be glad to learn if there is some!

Thanks!

@pfitzseb
Copy link
Member Author

pfitzseb commented Sep 6, 2021

Thanks for the report, will be fixed in #2431.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants