fix plot pane setting #1729
Merged
fix plot pane setting #1729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
reviewed
Oct 31, 2020
| @@ -1,105 +1,50 @@ | |||
| struct InlineDisplay <: AbstractDisplay end | |||
Member
There was a problem hiding this comment.
nit, it feels like InlineDisplay is now better to be renamed to VSCodeDisplay or such.
Member
Author
There was a problem hiding this comment.
Yeah, true. Not too bad though because it's not exported and VSCodeServer.InlineDisplay makes some sense ;)
Co-authored-by: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com>
aviatesk
approved these changes
Oct 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the plot pane setting apply instantly without needing to restart the Julia process. It's also much more robust against other packages trying to inject their own displays above ours.
Also simplifies a bunch of
display/displayabledefinitions.