add cd/activate cmds to explorer and file #1743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfitzseb
commented
Nov 4, 2020
| "command": "language-julia.executeFile", | ||
| "title": "Julia: Execute File" | ||
| "title": "Julia: Execute File", | ||
| "icon": "$(play)" |
Member
Author
There was a problem hiding this comment.
Unrelated fix to make sure we display an icon above the editor to run a file instead of the command's title.
aviatesk
reviewed
Nov 4, 2020
Member
aviatesk
left a comment
aviatesk
left a comment
There was a problem hiding this comment.
Left few minor comments, but the code looks good to me in general.
Just to make sure, the current command definitions allows us to invoke them from explorer via GUI and also from keyboard shortcuts ? I would like to be able to invoke them from keyboard shortcut as in Juno.
aviatesk
reviewed
Nov 4, 2020
Co-authored-by: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com>
Co-authored-by: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com>
Member
Author
Yep. VSCode gives us the right URI in all contexts I've tried. |
aviatesk
approved these changes
Nov 4, 2020
add 'Activate Parent Environment' command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1742.