Skip to content

Conversation

@pfitzseb
Copy link
Member

@pfitzseb pfitzseb commented Nov 5, 2020

Otherwise we can end up loading the wrong version of VSCodeServer, depending on how LOAD_PATH was set.

@fredrikekre
Copy link
Member

Same here:

Base.push!(LOAD_PATH, joinpath(@__DIR__, "..", "packages"))
import VSCodeDebugger
pop!(LOAD_PATH)

@fredrikekre
Copy link
Member

I'll just note that this trick:

"julia.environmentPath": "./scripts/environments/development"
will not work after this, but IMO it is better to foolproof the extension rather than simplify for developers.

@pfitzseb pfitzseb force-pushed the sp/pushfirstloadpath branch from 1921004 to 2d14a10 Compare November 5, 2020 11:03
@pfitzseb
Copy link
Member Author

pfitzseb commented Nov 5, 2020

Yep. It doesn't make much sense to have that for development anyways; much easier to modify the code in scripts/packages directly.

@pfitzseb pfitzseb merged commit 3b51f00 into master Nov 5, 2020
@davidanthoff davidanthoff deleted the sp/pushfirstloadpath branch February 11, 2021 19:47
@oppo-source oppo-source removed the request for review from a team April 16, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants