better env watching #1756
Merged
better env watching #1756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I guess the PR currently only changes vscode's file watcher to node's polling, right ? Not sure which part does:
(I assume this means we will watch for the currently active project and also for global environment (like v1.6) if the current active one is not the global one) |
Member
Author
|
|
Member
|
Makes sense. And I think we don't need to try to watch both env files for now; currently the LS is only able to handle one single environment anyway. |
aviatesk
reviewed
Nov 10, 2020
aviatesk
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if we want this, but it's very convenient to also watch the global environment for changes and re-index if necessary.