Skip to content

Conversation

@pfitzseb
Copy link
Member

This switches our code-eval keybindings to something close to Jupyter and makes sure our kbds aren't used in jupyter notebooks.

Copy link
Member

@aviatesk aviatesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I would like to wait for approve from @davidanthoff before merging tho

@aviatesk
Copy link
Member

aviatesk commented Dec 8, 2020

Could you take a look at this, @davidanthoff ?
Well I think we can move forward with this anyway; afaiu the keybindings are just compatible with the Jupyter extension's.

@davidanthoff
Copy link
Member

I would do this once the notebook stuff in base VS Code has shipped and we are sure that we know what their final choices will be.

@davidanthoff
Copy link
Member

Or wait, is this not actually updating our keybindings, but just making sure that they are not used in the notebook UI? In that case, I'm in favor, of course.

@pfitzseb
Copy link
Member Author

I was sneaky -- it does both. I actually thought the November release would finalize the Notebook API, but it turns out it didn't. It does seem very unlikely that the notebook keybindings will change though.

@pfitzseb pfitzseb mentioned this pull request Dec 21, 2020
@davidanthoff davidanthoff added this to the Backlog milestone Mar 12, 2021
@oppo-source oppo-source removed the request for review from a team April 16, 2021 07:35
@pfitzseb pfitzseb mentioned this pull request Jul 19, 2021
@pfitzseb pfitzseb closed this Jul 19, 2021
@davidanthoff davidanthoff deleted the sp/jupyterkbds branch August 13, 2022 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants