Skip to content

Conversation

@pfitzseb
Copy link
Member

@pfitzseb pfitzseb commented Dec 4, 2020

No description provided.

@davidanthoff
Copy link
Member

This kind of has the potential to mess things up, right? I think we can try it, but a more robust implementation might be to not pass the flag, but instead run the startup script after the whole debugger has been initialized. And maybe have an option for this in the launch config? But for now I'd say we can give it a shot as is.

@pfitzseb
Copy link
Member Author

Ah, fair point. I'll change this to load startup.jl in our launch script instead.

Copy link
Member

@davidanthoff davidanthoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I could also imagine that we move the call to load_julia_startup to even later, essentially just before the message queue starts to run. But maybe lets try this one first here, my worry might well be a bit academic :)

@davidanthoff davidanthoff merged commit 562b708 into master Dec 15, 2020
@davidanthoff davidanthoff deleted the sp/debuggerstartupfile branch December 15, 2020 18:25
@oppo-source oppo-source removed the request for review from a team April 16, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants