Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config options for new completions modes (ver 2) #1963

Merged
merged 3 commits into from May 19, 2021
Merged

Add config options for new completions modes (ver 2) #1963

merged 3 commits into from May 19, 2021

Conversation

ZacLN
Copy link
Contributor

@ZacLN ZacLN commented Feb 19, 2021

Fixes #.

For every PR, please check the following:

  • End-user documentation check. If this PR requires end-user documentation, please add that at https://github.com/julia-vscode/docs.
  • Changelog mention. If this PR should be mentioned in the CHANGELOG, please edit the CHANGELOG.md file in this PR.

@ZacLN ZacLN mentioned this pull request Feb 19, 2021
Closed
2 tasks
@davidanthoff davidanthoff added this to the Next Minor milestone Feb 19, 2021
davidanthoff
davidanthoff requested changes Mar 12, 2021
View reviewed changes
Copy link
Member

@davidanthoff davidanthoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a merge conflict resolution.

@davidanthoff davidanthoff added this to Changes requested in v1.2 Mar 12, 2021
@davidanthoff davidanthoff moved this from Changes requested to Done in v1.2 May 12, 2021
@davidanthoff davidanthoff merged commit 3b82ec1 into master May 19, 2021
@davidanthoff davidanthoff deleted the comp-config branch May 19, 2021 16:35
@davidanthoff davidanthoff moved this from Done to Merged in v1.2 May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidanthoff davidanthoff davidanthoff approved these changes

@pfitzseb pfitzseb pfitzseb approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
No open projects
v1.2
Merged
Milestone
Next Feature Release
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ZacLN @davidanthoff @pfitzseb