Skip to content

Allocation profiler and some profiler tweaks #2890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 24, 2022
Merged

Allocation profiler and some profiler tweaks #2890

merged 5 commits into from
May 24, 2022

Conversation

@pfitzseb
Copy link
Member

@pfitzseb pfitzseb commented May 12, 2022

image

  • adds @profview_allocs/view_alloc_profile
  • flame graph view of allocations is scaled with x^1/5 because of the big differences in magnitude of allocation
  • in-editor display is now always relative to root count
  • percentage displayed in flame graph is now always relative to root count

aviatesk
aviatesk reviewed May 20, 2022
View reviewed changes
aviatesk
aviatesk reviewed May 20, 2022
View reviewed changes
pfitzseb and others added 2 commits May 20, 2022 12:00
@pfitzseb @aviatesk
Update scripts/packages/VSCodeServer/src/profiler.jl
998b973 
Co-authored-by: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com>
@pfitzseb
better code
650a4b8 
and add two alloc profiler modes
@pfitzseb
Copy link
Member Author

pfitzseb commented May 20, 2022 •
edited
Loading

This now supports a count and an size mode, much like PProf:
image
image

@pfitzseb pfitzseb marked this pull request as ready for review May 24, 2022 10:54
@pfitzseb pfitzseb merged commit d30fc70 into master May 24, 2022
@aviatesk aviatesk deleted the sp/allocation-profiler branch May 24, 2022 10:55
@aviatesk
Copy link
Member

aviatesk commented May 24, 2022

Yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aviatesk aviatesk aviatesk left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pfitzseb @aviatesk