Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make value_and_pullback_function a primitive instead of pullback_function #34

Closed
sethaxen opened this issue Jan 20, 2022 · 0 comments · Fixed by #93
Closed

Make value_and_pullback_function a primitive instead of pullback_function #34

sethaxen opened this issue Jan 20, 2022 · 0 comments · Fixed by #93

Comments

@sethaxen
Copy link
Member

Currently the internals use closures to avoid computing the primal more than once, but it would be easier to read, simpler, and more consistent with ChainRules, Zygote, Diffractor, etc to instead make value_and_pullback_function the primitive. Should come after #4.

Not certain if the same should be done for pushforward_function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant