-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVG paths in the logos are not closed #17
Comments
The following SVGs are relevant. The PDFs have not been checked.
There is a similar problem in |
@cormullion Happy release of Luxor.jl v4.0! 🎉 |
@kimikage Thanks! The files here weren't created with Julia or Luxor (which they likely predate). I think they were created in some editor and then minimized using svgomg or similar to reduce file size to a minimum. I don' think there's an official design specification anywhere. (And certainly nothing as detailed as this branding guide.) As these graphics are intellectual property (ie copyright/trademark of Stefan and the Julia project), I think it's OK to use derivative versions to make Julia-related graphics in Luxor, but I wouldn't want to get into modifying or prescribing anything here. |
I understand. I noticed this problem in the process of generating a mesh from the SVG. I'm leaving this issue open in case anyone else encounters a similar problem. |
@cormullion If you have Luxor code to generate correct SVGs that look right, I'd be happy to switch to having the output of those be official rather than these, which were created by @jiahao many years ago from a PDF exported from Keynote. (We are design professionals here!) Having Luxor code that generates the SVGs and having those be official is much cleaner and preferable! |
There are two different types of problems.
1. non-dot glyphs
The first problem concerns the non-dot glyphs in the logos.
julia-logo-graphics/images/julia-logo-color.svg
Line 4 in f3a09eb
They have the same coordinates as the "M" points but are not topologically closed (without "Z").
The output paths are closed with the current version of Luxor. 🤔
2. dots
The second problem concerns the dots in the logos.
The paths of dots are not closed either.
However, for this matter, the path definitions in Luxor are not closed.
https://github.com/JuliaGraphics/Luxor.jl/blame/71415993d515e2ef4b2ae461d1b59793bd5facb0/src/juliagraphics.jl#L191-L221
Note that the arc (”A”) of the SVG path is a bit complicated, so I agree with the approximation with four Bezier curves.
off-topic
The marked line segment is formally defined as a curve.
https://github.com/JuliaGraphics/Luxor.jl/blame/71415993d515e2ef4b2ae461d1b59793bd5facb0/src/juliagraphics.jl#L109
They have the same x-coordinate, i.e., they are on a straight line. 😄
The text was updated successfully, but these errors were encountered: