Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid creating inner http server for browser-run session #29

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@3cp
Copy link

commented Jun 11, 2019

closes #28

@juliangruber
Copy link
Owner

left a comment

thanks for adding a test! could you document this as well? it doesn't have to be "this is for browser-run" but could be more generic like "pass this if you want to use an existing http server"

@3cp

This comment has been minimized.

Copy link
Author

commented Jun 11, 2019

That's a valid point, I will update code comment and README.md for your review.

If I understand it correctly, once you provide opts.loc, you cannot use browser.write(...), because the inner sourceFile is only for inner http server.

@3cp 3cp force-pushed the 3cp:reuse-browser-run-server branch from baa5ad4 to ae7bcf3 Jun 11, 2019

@3cp

This comment has been minimized.

Copy link
Author

commented Jun 13, 2019

@juliangruber could you review the changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.