New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resume test using raf (#12) #15

Merged
merged 2 commits into from Aug 24, 2016

Conversation

Projects
None yet
2 participants
@joehand
Collaborator

joehand commented Aug 4, 2016

PR adds a test, currently failing, for testing the mtime bug with raf and files on fs.

@joehand

This comment has been minimized.

Show comment
Hide comment
@joehand

joehand Aug 9, 2016

Collaborator

Passing with your hyperdrive PR! Amended my last commit with the correct t.plan() count.

Collaborator

joehand commented Aug 9, 2016

Passing with your hyperdrive PR! Amended my last commit with the correct t.plan() count.

@juliangruber

This comment has been minimized.

Show comment
Hide comment
@juliangruber

juliangruber Aug 9, 2016

Owner

W00P! Just need to get the hyperdrive PR merged now. cc @mafintosh hehehe

Owner

juliangruber commented Aug 9, 2016

W00P! Just need to get the hyperdrive PR merged now. cc @mafintosh hehehe

@joehand

This comment has been minimized.

Show comment
Hide comment
@joehand

joehand Aug 17, 2016

Collaborator

Bumped hyperdrive hoping that'd make the tests pass but Travis is still having trouble.

These pass locally, maybe its the same travis bug you were having with the other tests?

Collaborator

joehand commented Aug 17, 2016

Bumped hyperdrive hoping that'd make the tests pass but Travis is still having trouble.

These pass locally, maybe its the same travis bug you were having with the other tests?

@juliangruber

This comment has been minimized.

Show comment
Hide comment
@juliangruber

juliangruber Aug 17, 2016

Owner

the problem before was with life mode, maybe we can get resume to work though

Owner

juliangruber commented Aug 17, 2016

the problem before was with life mode, maybe we can get resume to work though

@juliangruber

This comment has been minimized.

Show comment
Hide comment
@juliangruber

juliangruber Aug 24, 2016

Owner

i restarted the build and it passes now! woop woop

Owner

juliangruber commented Aug 24, 2016

i restarted the build and it passes now! woop woop

@juliangruber juliangruber merged commit 9df2ea7 into juliangruber:master Aug 24, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment