Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fullPage.js — All data-sr elements (even out of view) are starting instantly. #14

Closed
DamChtlv opened this issue Jan 30, 2014 · 3 comments

Comments

@DamChtlv
Copy link

Hi,

First of all, i would like to say this script is awesome, I'm loving it but it seems to doesn't work with fullPage.js from Alvarotrigo because it starts all scrolls elements on the loading of the page, so when i'm moving on other slides, all of the elements are already loaded.

So maybe you could add an option like data-sr='enter left and move 50px on Slide1 hover. (In this example, Slide1 is an ID or class.)

Hope you can resolve this :)

@jlmakes
Copy link
Owner

jlmakes commented Feb 3, 2014

scrollReveal event triggers are on the roadmap, for what sounds like the use case you’re describing: reveal animations triggered on specific events, not necessarily on scroll.

The tentative syntax would be something like enter top and move 20px triggered on <eventname>

Does this sound like what you’re looking for?

@DamChtlv
Copy link
Author

DamChtlv commented Feb 3, 2014

Yes, that's totally what i am looking for !

Are you planning on adding this feature ?

@jlmakes
Copy link
Owner

jlmakes commented Feb 4, 2014

Yep, I’ve got something like on the roadmap for sure. I’m not sure if this will be in the next release, but I think the flexibility to define custom-events that override/supplement the default scroll-based behavior would be nice.

I think the first step though, is allowing manual initialization of scrollReveal—so you can do so after something like fullpage.js does its work.

jlmakes pushed a commit that referenced this issue Feb 13, 2014
@jlmakes jlmakes closed this as completed Feb 13, 2014
jlmakes pushed a commit that referenced this issue Feb 13, 2014
@jlmakes jlmakes removed bug labels Apr 23, 2014
@jlmakes jlmakes changed the title All data-scrollreveal elements are starting instantly even when i don't scroll to them. fullPage.js — All data-sr elements (even out of view) are starting instantly. Oct 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants