New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE 8, filter attribute isn't persisted #506

Closed
msurguy opened this Issue May 6, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@msurguy

msurguy commented May 6, 2015

It appears that velocity is not keeping track of existing 'filter:' attributes that are on the object and instead is overwriting them with a single 'filter' (in case of opacity). According to MS specs, there could be multiple filters applied simultaneously by separating them with a space: https://msdn.microsoft.com/en-us/library/ms532847(v=vs.85).aspx. It would be nice if Velocity would keep existing filters such as blur intact and only add additional filters (opacity) separated by a space.

Here is a demo that doesn't work properly in IE8 because of this bug:
http://codepen.io/msurguy/pen/pJjdrz

@ydaniv

This comment has been minimized.

Show comment
Hide comment
@ydaniv

ydaniv May 7, 2015

Contributor

Thanks @msurguy. @julianshapiro needs considering if this doesn't require DOM reading and is worth the overhead.

Contributor

ydaniv commented May 7, 2015

Thanks @msurguy. @julianshapiro needs considering if this doesn't require DOM reading and is worth the overhead.

@Rycochet

This comment has been minimized.

Show comment
Hide comment
@Rycochet

Rycochet Nov 23, 2017

Collaborator

IE8 is no longer supported in v2 - there will be a legacy layer at some point, but how this is dealt with is now totally different.

Collaborator

Rycochet commented Nov 23, 2017

IE8 is no longer supported in v2 - there will be a legacy layer at some point, but how this is dealt with is now totally different.

@Rycochet Rycochet closed this Nov 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment