IE8 error, 'hasOwnProperty' not supported on window.performance #738

Closed
a10nik opened this Issue Jan 3, 2017 · 1 comment

Projects

None yet

2 participants

@a10nik
Contributor
a10nik commented Jan 3, 2017

Velocity throws

Object doesn't support property or method 'hasOwnProperty'

on load.

To reproduce the error, just include <script src="https://cdnjs.cloudflare.com/ajax/libs/velocity/1.4.1/velocity.js"></script> into empty html and open it either in IE8 emulation mode or in a real IE8.

It's happening since 7255f4c. In IE8 for some reason window.performance is not considered a proper Object and therefore lacks its prototype methods including hasOwnProperty.

In case you're planning to discontinue IE8 support, better declare it on the main page and close the issue.

@a10nik a10nik added a commit to a10nik/velocity that referenced this issue Jan 3, 2017
@a10nik a10nik Fix IE8 lacking hasOwnProperty on window.performance. Fixes #738 8208984
@Rycochet Rycochet closed this in d636d62 Jan 4, 2017
@Rycochet
Collaborator
Rycochet commented Jan 4, 2017

A lot of IE8 "objects" aren't really objects at all - need to note all of the IE fixes for version 2 where they're getting removed (hopefully a couple more releases before then though).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment