-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change ApproxFun{Base,Fourier} bounds? #306
Comments
I don't know where those came from: I'm using https://github.com/JuliaApproximation/ApproxFunBase.jl/blob/master/Project.toml |
Are all of those versions compatible with 1.1, 1.2, etc.? If so, I'll make a PR to fix this. |
I think they got in when Registrator was bugged, e.g. #199 (comment) |
Note that ApproxManifoldProducts did not, it was introduced earlier: 50f9d5f. It may be legit. |
Well 1.2, 1.3, etc. don't exist yet, but I assume they will be compatible. (This assumption may of course be wrong: for example, some older versions worked in Julia v1.0 but not in Julia v1.1 due to change in the behaviour of I don't recognize "ApproxManifoldProducts". |
Ok, I just guessed that anything with the word "Approx" in it was yours 😁 |
Indeed, the cap there seems intentional, although I'm not sure why: https://github.com/JuliaRobotics/ApproxManifoldProducts.jl/blob/c62dcf90241541115c7/REQUIRE |
I wouldn't bother correcting it for ApproxFun*. I'm about to tag a version |
I'm fixing all the incorrect bounds that were introduced by this bug, so it's all the same to me. |
@dlfivefifty, these bounds on your packages look suspicious:
Can you confirm or deny that these should be changed to
0.7-1
?The text was updated successfully, but these errors were encountered: