Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change ApproxFun{Base,Fourier} bounds? #306

Closed
StefanKarpinski opened this issue Apr 25, 2019 · 9 comments · Fixed by #307
Closed

change ApproxFun{Base,Fourier} bounds? #306

StefanKarpinski opened this issue Apr 25, 2019 · 9 comments · Fixed by #307

Comments

@StefanKarpinski
Copy link
Contributor

@dlfivefifty, these bounds on your packages look suspicious:

A/ApproxFunBase/Compat.toml
32-["0.0.4"]
33:julia = "0.7-1.1"

A/ApproxFunFourier/Compat.toml
27-["0.0.2-0"]
31:julia = "0.7-1.1"

A/ApproxManifoldProducts/Compat.toml
14-["0.0.2-0"]
16:julia = "0.7-1.1"

Can you confirm or deny that these should be changed to 0.7-1?

@dlfivefifty
Copy link
Contributor

I don't know where those came from: I'm using julia = 0.7, 1.0 which I assumed would be 0.7-2.0-:

https://github.com/JuliaApproximation/ApproxFunBase.jl/blob/master/Project.toml

@StefanKarpinski
Copy link
Contributor Author

Are all of those versions compatible with 1.1, 1.2, etc.? If so, I'll make a PR to fix this.

@fredrikekre
Copy link
Member

I think they got in when Registrator was bugged, e.g. #199 (comment)

@StefanKarpinski
Copy link
Contributor Author

Note that ApproxManifoldProducts did not, it was introduced earlier: 50f9d5f. It may be legit.

@dlfivefifty
Copy link
Contributor

Well 1.2, 1.3, etc. don't exist yet, but I assume they will be compatible. (This assumption may of course be wrong: for example, some older versions worked in Julia v1.0 but not in Julia v1.1 due to change in the behaviour of lmul!. )

I don't recognize "ApproxManifoldProducts".

@StefanKarpinski
Copy link
Contributor Author

Ok, I just guessed that anything with the word "Approx" in it was yours 😁

@StefanKarpinski
Copy link
Contributor Author

StefanKarpinski commented Apr 25, 2019

Indeed, the cap there seems intentional, although I'm not sure why:

https://github.com/JuliaRobotics/ApproxManifoldProducts.jl/blob/c62dcf90241541115c7/REQUIRE

@dlfivefifty
Copy link
Contributor

I wouldn't bother correcting it for ApproxFun*. I'm about to tag a version 0.1, and worrying about old 0.0.x versions not working in 1.2 does not seem a good use of your time.

@StefanKarpinski
Copy link
Contributor Author

I'm fixing all the incorrect bounds that were introduced by this bug, so it's all the same to me.

@StefanKarpinski StefanKarpinski changed the title change ApproxFun{Base,Fourier,ManifoldProducts} bounds? change ApproxFun{Base,Fourier} bounds? Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants