Add hasDRM() and update typings
#44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavdid
commented
Nov 3, 2019
| export = EPub; | ||
| import { EventEmitter } from 'events' | ||
|
|
||
| declare class EPub extends EventEmitter { |
There was a problem hiding this comment.
this was auto-formatted with prettier, sorry about that. It happens by default in my editor, so it happened at one point while editing. If it's a sticking point, i'm happy to go through and un-format it.
xavdid
commented
Nov 3, 2019
| export = EPub | ||
|
|
||
| declare namespace EPub { | ||
| export interface TocElement { |
There was a problem hiding this comment.
This pattern allows things like:
import EPub = require('epub')
import { TocElement } from 'epub'
const func = (book: EPub, chapter: TocElement) => ...
|
Looks like there's a test failure. Maybe try updating the |
|
LGTM, thanks! |
|
(if you find a way to fix the tests that'd be awesome) |
|
sure, I'll take a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
This PR adds one function:
hasDRM()it checks for the existence of the encryption file, and if it's there, the book is protected. I didn't add a test here, but the functionality is tested where I use it, here.I also updated your typescript definitions. I was following this blueprint. I also updated the triple-slash directive per these instructions.
Thanks a bunch!