Fix #315 #342 #343
Merged
Fix #315 #342 #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 9, 2016 16:40
Fix issue in Bits where singleBit for Long was shitfing bits incorrectly Add random index for IndexTests/OptionalTests using ScalaCheck
| @@ -43,6 +43,7 @@ lazy val buildSettings = Seq( | |||
| lazy val scalaz = Def.setting("org.scalaz" %%% "scalaz-core" % "7.2.1") | |||
| lazy val shapeless = Def.setting("com.chuusai" %%% "shapeless" % "2.3.0") | |||
| lazy val refinedDep = Def.setting("eu.timepit" %%% "refined" % "0.3.7") | |||
| lazy val refinedScalaCheckDep = Def.setting("eu.timepit" %%% "refined-scalacheck" % "0.3.7") | |||
There was a problem hiding this comment.
can you add "test" modifier
|
Updated! I had to move the dependency for it to compile, let me know if there's anything else you want changed :) |
| sEq: Equal[S], sArb: Arbitrary[S], | ||
| iArb: Arbitrary[I], evAt: At[S, I, A]): RuleSet = { | ||
| new SimpleRuleSet("At", LensTests(at(_: I)).props: _*) | ||
| } | ||
|
|
||
| def defaultIntIndex[S, A](implicit aEq: Equal[A], aArb: Arbitrary[A], |
There was a problem hiding this comment.
we can probably remove defaultIntIndex
|
Thank you very much, it is awesome to write tests that actually find bugs :) |
… no longer necessary Also, modified code format broken by intelliJ
|
No, thank you! It was fun and I learned :) I've removed the methods, updated code to user the 'proper' apply way, and fixed the styling (hopefully). Let me know if you want me to tweak something else, as IntelliJ may do stuff I don't realise... :eh: |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue in Bits where singleBit for Long was shitfing bits incorrectly
Add random index for IndexTests/OptionalTests using ScalaCheck