Issue 649 d #658
Merged
Issue 649 d #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @spf3000 for investigating it and nice quick win :) |
cquiroz
pushed a commit
to cquiroz/Monocle
that referenced
this pull request
Jun 24, 2019
…dev#658) * remove compiler warnings where they are backwards compatible * add metals to gitignore
julien-truffaut
pushed a commit
that referenced
this pull request
Jun 25, 2019
* remove compiler warnings where they are backwards compatible * add metals to gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I realised that in order to implement fixes that aren't backwards compatible we are going to have to duplicate at least significant portions of the code base, if not all of it. It's probably not a price you are willing to pay, understandably. Hence only the ones (2 of them!) with a backwards compatible fix have been added.