Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show timeout / no route to host #24

Open
JonyIvy opened this issue Nov 29, 2023 · 3 comments
Open

Show timeout / no route to host #24

JonyIvy opened this issue Nov 29, 2023 · 3 comments
Assignees

Comments

@JonyIvy
Copy link

JonyIvy commented Nov 29, 2023

I love this little program, thank you!, and I have a suggestion for improvement:

When there is no network connection, regular 'ping' shows 'no route to host' and 'request timeout'. It would be nice if this could be reflected in the menu bar. Currently it just keeps showing the last successful ping's time, which is misleading.

@JonyIvy
Copy link
Author

JonyIvy commented Dec 2, 2023

I have seen a yellow dot on one occasion, which probably means there is no connection?
But usually when I lose the network connection, that is turning WiFi off or unplugging the connection to the dock, MenuPing keeps showing the last ping value (while ping in the command line shows 'no route to host / request timeout').

@julienbordet julienbordet self-assigned this Dec 12, 2023
@julienbordet
Copy link
Owner

Hi @JonyIvy

I'm glad you like MenuPing.

Internally MenuPing uses the ping3 python library, that returns :

  • either False on error -> that is printed with a Red dot
  • either None on timeout -> that is printed with a Yellow dot

"Error" (red dot) generally means that the domain name was false (which should not be the case with MenuPing, except if you change the target domain to a non existant one), or that there was network error (for instance, that you switched your Wifi off).

I have not observed that when switching the Wifi off, the last ping value is still showing in my environment.

Could you confirm if it is always the case ?

@JonyIvy
Copy link
Author

JonyIvy commented Dec 12, 2023

Yes it always keeps showing the last value, whether I'm on WiFi and turn WiFi off, or I'm on dock/hub with Ethernet and disconnect the dock.
MacOS 13.6.2 (22G320)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants