Mount the debugbar engine automatically#51
Merged
julienbourdeau merged 1 commit intomasterfrom Jan 8, 2025
Merged
Conversation
It also shows warning logs to help you upgrade your codebase. The following block should be removed from your `config/routes.rb` ``` if defined? Debugbar mount Debugbar::Engine => Debugbar.config.prefix end ```
julienbourdeau
force-pushed
the
feat/load-routes-automatically
branch
from
2d8fb02 to
4148239
Compare
julienbourdeau
commented
Jan 8, 2025
| initializer "debugbar.append_routes" do |app| | ||
| # Before 0.5.0, I asked people to mount the engine manually | ||
| # This will probably throw an error at some point to be ultimately removed | ||
| app.routes.append do |
Owner
Author
There was a problem hiding this comment.
Notice that we append to be able to check of the route was already defined (by the main app routes.rb file).
You'd get an error if you try to mount the same engine twice.
julienbourdeau
added a commit
to julienbourdeau/debugbar.dev
that referenced
this pull request
Jan 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It also shows warning logs to help you upgrade your codebase. The following block should be removed from your
config/routes.rbI dunno why this wasn't done originally 🤷♂️