Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateRFC3339TypeAdapter is not thread-safe #24

Closed
npanasenko opened this issue Dec 11, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@npanasenko
Copy link

commented Dec 11, 2015

Weird bugs appeared in my application when DateRFC3339TypeAdapter was called simultaneously from different Threads. The RFC3339DateFormat seems to cause the problem.

@julman99

This comment has been minimized.

Copy link
Owner

commented Dec 11, 2015

Thanks for reporting this, I will check during the weekend.

Can you be more specific on what kind of bugs you got? serialization bugs? weird exceptions?

@npanasenko

This comment has been minimized.

Copy link
Author

commented Dec 12, 2015

When multiple threads deserialize dates concurrently it is possible that the Threads return due to racing conditions wrong dates, sometimes the result of the other thread.

julman99 added a commit that referenced this issue Dec 13, 2015

@julman99 julman99 added the bug label Dec 13, 2015

@julman99 julman99 closed this in 518f506 Dec 13, 2015

@julman99

This comment has been minimized.

Copy link
Owner

commented Dec 13, 2015

Please try version 1.5.0 and let me know if it fixes the issue

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.