Skip to content

Conversation

@odow
Copy link
Member

@odow odow commented Oct 1, 2020

Closes #295
Closes #309

Co-authored-by: metab0t <metab0t@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #321 into master will increase coverage by 0.73%.
The diff coverage is 95.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
+ Coverage   54.08%   54.82%   +0.73%     
==========================================
  Files           7        7              
  Lines        2703     2747      +44     
==========================================
+ Hits         1462     1506      +44     
  Misses       1241     1241              
Impacted Files Coverage Δ
src/MOI/MOI_wrapper.jl 89.40% <95.55%> (+0.20%) ⬆️
src/gen/libcpx_api.jl 7.39% <0.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bf4a84...fb46992. Read the comment docs.

@odow
Copy link
Member Author

odow commented Oct 4, 2020

Barring objections, I'll leave this open for another 48 hours, then merge.

@metab0t
Copy link
Contributor

metab0t commented Oct 4, 2020

I have just noticed that CPLEX.jl is rewritten based on auto-generated bindings with Clang.jl, which makes this package more maintainable. It also makes this PR cleaner. Thanks for your hard work @odow. It's really a new chapter for CPLEX.jl.

@odow
Copy link
Member Author

odow commented Oct 4, 2020

which makes this package more maintainable. It also makes this PR cleaner

Exactly. It needed to be done. Here's the PR, which contains some discussion you might be interested in reading: #316

@odow odow merged commit 3788bdf into master Oct 5, 2020
@odow odow deleted the od/qcqp_dual branch October 5, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Error when MOI tries to query the dual solution of a QCQP

4 participants