[Performance] don't pass names by default #393
Conversation
Codecov Report
@@ Coverage Diff @@
## master #393 +/- ##
==========================================
- Coverage 50.76% 50.57% -0.20%
==========================================
Files 7 7
Lines 3936 3937 +1
==========================================
- Hits 1998 1991 -7
- Misses 1938 1946 +8
Continue to review full report at Codecov.
|
|
|
||
| """ | ||
| Optimizer(env::Union{Nothing, Env} = nothing) | ||
| Optimizer(env::Union{Nothing, Env} = nothing; pass_names::Bool = false) |
There was a problem hiding this comment.
Why not an AbstractOptimizerAttribute?
There was a problem hiding this comment.
Because this is really a CPLEX.jl hack, rather than an option supported by CPLEX.
There was a problem hiding this comment.
Still, it would make sense to have attributes of the wrapper. I don't consider a hack, but an actual option of the wrapper.
The attribute (with a supports function) path is more generic, for users calling multiple solvers in a more abstract manner.
In fact, Xpress will require this eventually.
There was a problem hiding this comment.
I agree with @joaquimg. It could be optimizer_with_attributes(CPLEX.Optimizer, CPLEX.PassNames() => true)
Closes #392