Skip to content

Conversation

@mlubin
Copy link
Member

@mlubin mlubin commented Jul 11, 2020

Closes #1611
CC @mtanneau

src/variables.jl Outdated
- Binary constraints are deleted, and variable bounds are tightened if
necessary to ensure the variable is constrained to the interval ``[0, 1]``.
- Integrality constraints are deleted without modifying variable bounds.
- Semi-continuous and semi-integer constraints are ignored (left in place).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No error for semi-continuous, semi-integer, SOS constraints then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added an error for semi-continuous and semi-integer because we might want to add support for those in the future (and removing an error isn't a breaking change). I think SOS, indicator and other constraints are clearly out of scope (the name of the function is relax_integrality) and should be ignored. We can't possibly enumerate all types of constraints that might cause the problem to have discrete aspects.

@codecov
Copy link

codecov bot commented Jul 12, 2020

Codecov Report

Merging #2275 into master will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2275      +/-   ##
==========================================
+ Coverage   91.12%   91.26%   +0.13%     
==========================================
  Files          42       42              
  Lines        4192     4234      +42     
==========================================
+ Hits         3820     3864      +44     
+ Misses        372      370       -2     
Impacted Files Coverage Δ
src/variables.jl 97.57% <100.00%> (+1.43%) ⬆️
src/nlp.jl 92.79% <0.00%> (-0.03%) ⬇️
src/macros.jl 93.11% <0.00%> (+0.03%) ⬆️
src/aff_expr.jl 88.02% <0.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9aa2bf6...e0e5e29. Read the comment docs.

@mlubin mlubin merged commit 1129e58 into master Jul 13, 2020
@mlubin mlubin deleted the ml/relax branch July 13, 2020 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: solve relaxation

5 participants