-
-
Notifications
You must be signed in to change notification settings - Fork 411
Utility for relaxing integrality #2275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/variables.jl
Outdated
| - Binary constraints are deleted, and variable bounds are tightened if | ||
| necessary to ensure the variable is constrained to the interval ``[0, 1]``. | ||
| - Integrality constraints are deleted without modifying variable bounds. | ||
| - Semi-continuous and semi-integer constraints are ignored (left in place). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No error for semi-continuous, semi-integer, SOS constraints then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added an error for semi-continuous and semi-integer because we might want to add support for those in the future (and removing an error isn't a breaking change). I think SOS, indicator and other constraints are clearly out of scope (the name of the function is relax_integrality) and should be ignored. We can't possibly enumerate all types of constraints that might cause the problem to have discrete aspects.
Codecov Report
@@ Coverage Diff @@
## master #2275 +/- ##
==========================================
+ Coverage 91.12% 91.26% +0.13%
==========================================
Files 42 42
Lines 4192 4234 +42
==========================================
+ Hits 3820 3864 +44
+ Misses 372 370 -2
Continue to review full report at Codecov.
|
Closes #1611
CC @mtanneau