-
-
Notifications
You must be signed in to change notification settings - Fork 411
Improve minimal ellipses SDP demonstration #2945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2945 +/- ##
=======================================
Coverage 95.42% 95.42%
=======================================
Files 43 43
Lines 5794 5794
=======================================
Hits 5529 5529
Misses 265 265 Continue to review full report at Codecov.
|
odow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Two comments:
- The documentation build is failing https://github.com/jump-dev/JuMP.jl/runs/5967440505?check_suite_focus=true. I've left some in-line comments with what needs to change
- To ensure consistency, we run a code formatter that is failing. Take a look here, https://github.com/jump-dev/JuMP.jl/runs/5967440511?check_suite_focus=true, and implement the changes it suggests.
Once you fix the failures, it'll make a preview of the documentation and we can see how your plot looks 😄
odow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better
This PR improves the "Minimum ellipses" demonstration in the documentation:
(Logdet is correct, but the
MOI.RootDetConeTriangleinterface wasn't working at the time the previous version of this demo was created, so the author used trace as an approximation.)See this discussion on Discourse.