Skip to content

Conversation

@maxkapur
Copy link
Contributor

This PR improves the "Minimum ellipses" demonstration in the documentation:

  • Fixed the objective function to use the log determinant of the matrix instead of the trace.
    (Logdet is correct, but the MOI.RootDetConeTriangle interface wasn't working at the time the previous version of this demo was created, so the author used trace as an approximation.)
  • Allow input ellipses that aren't centered at the origin.
  • Add section number to textbook reference.
  • Add graphical output.
  • Change title from "Minimum ellipses" to "Minimal ellipses."

See this discussion on Discourse.

@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #2945 (bfbd05c) into master (e8d656c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2945   +/-   ##
=======================================
  Coverage   95.42%   95.42%           
=======================================
  Files          43       43           
  Lines        5794     5794           
=======================================
  Hits         5529     5529           
  Misses        265      265           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8d656c...bfbd05c. Read the comment docs.

Copy link
Member

@odow odow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Two comments:

Once you fix the failures, it'll make a preview of the documentation and we can see how your plot looks 😄

Copy link
Member

@odow odow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better

@odow odow merged commit a22f19a into jump-dev:master Apr 11, 2022
@odow odow mentioned this pull request Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants