-
-
Notifications
You must be signed in to change notification settings - Fork 411
implement getsolvetime. issue #405 #422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
LGTM. The only question is if we should follow the MPB naming convention here, given that we decided to do so for |
src/solvers.jl
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's more Julia-like (for type stability reasons) to throw an exception when the value isn't available instead of returning nothing.
|
@IainNZ @joehuchette, comments on the naming issue? |
|
I'm leaning towards MathProgBase version, for now. |
|
I think I agree with Iain in theory, except for the fact that the current way to call it is so verbose with |
|
@joehuchette, this wrapper lets you call it without |
|
Understood, I'm thinking that I would just prefer a shorter alias for |
|
@joehuchette, the wrapper method lets you give a nice error message when the solver doesn't implement |
|
@odow, we can merge this as is. Could you squash the commits? |
|
@mlubin squashed. |
implement getsolvetime. issue #405
|
Thanks! |
Exposes
MathProgBase.getsolvetimeand checks if implemented by solver. #405