Add ZeroOneBridge #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

blegat merged 13 commits into jump-dev:master from rtwalker:rw/zero_one_bridge

Jul 13, 2020

Contributor

rtwalker commented Jun 1, 2020

Attempting to resolve #704.

Contributor Author

rtwalker commented Jun 1, 2020

Only basic tests added for now. I'm not sure that I understand yet what is happening in the set_mock_optimize! test

odow reviewed

View reviewed changes

docs/src/apimanual.md Outdated Show resolved Hide resolved

src/Bridges/Constraint/zero_one.jl Outdated Show resolved Hide resolved

blegat reviewed

View reviewed changes

src/Bridges/Constraint/zero_one.jl Outdated Show resolved Hide resolved

blegat reviewed

View reviewed changes

src/Bridges/Constraint/zero_one.jl Outdated Show resolved Hide resolved

blegat reviewed

View reviewed changes

src/Bridges/Constraint/zero_one.jl Outdated Show resolved Hide resolved

blegat reviewed

View reviewed changes

src/Bridges/Constraint/zero_one.jl Outdated Show resolved Hide resolved

blegat reviewed

View reviewed changes

src/Bridges/Constraint/zero_one.jl Outdated Show resolved Hide resolved

blegat reviewed

View reviewed changes

src/Bridges/Constraint/zero_one.jl Outdated Show resolved Hide resolved

blegat reviewed

View reviewed changes

src/Bridges/Constraint/zero_one.jl Outdated Show resolved Hide resolved

blegat reviewed

View reviewed changes

src/Bridges/Constraint/zero_one.jl Outdated Show resolved Hide resolved

blegat reviewed

View reviewed changes

src/Bridges/Constraint/zero_one.jl Outdated Show resolved Hide resolved

blegat reviewed

View reviewed changes

src/Bridges/Constraint/zero_one.jl Outdated Show resolved Hide resolved

blegat reviewed

View reviewed changes

src/Bridges/Constraint/zero_one.jl Outdated Show resolved Hide resolved

src/Bridges/Constraint/zero_one.jl Outdated Show resolved Hide resolved

src/Bridges/Constraint/zero_one.jl Show resolved Hide resolved

blegat reviewed

View reviewed changes

src/Bridges/Constraint/zero_one.jl Show resolved Hide resolved

blegat mentioned this pull request

Fix order ListOfConstraintIndices with constraint bridges on variable function #1114

Merged

Member

blegat commented Jul 2, 2020

Can you rebase, the tests might pass now with #1114

rtwalker added 12 commits

July 3, 2020 09:36


          add zero one to integer bridge

7a2e324


          typo fix

2466f11


          add basic tests

1619e82


          don't break cross referencing

14636f3


          change less than and greater than into interval

954a23c


          add more tests

7d83746


          typo fix

0455b02


          update list of bridges in reference

8a803a6


          address comments


          more comments

2f9d16f


          include added_constrained_variable_types

7baef42


          remove a lingering VariableIndex field from bridge constructor

15287db

rtwalker force-pushed the rw/zero_one_bridge branch from 109bb00 to 15287db Compare

July 3, 2020 13:36


          add test for deleting bridge

151b1c3

blegat approved these changes

View reviewed changes

blegat added this to the v0.9.15 milestone

blegat merged commit 12f1d5c into jump-dev:master

Member

blegat commented Jul 13, 2020

Thanks @rtwalker !

Contributor Author

rtwalker commented Jul 13, 2020

A huge thanks @blegat and @odow for the help!

Bridges are a really slick feature, and I enjoyed learning about how they work.

rtwalker deleted the rw/zero_one_bridge branch

July 13, 2020 22:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet